Ship a change: edit until tests pass, review, approve once

---
name: ship-a-change
description: Implements a change in a loop on the test suite, reviews the diff in parallel, gates it in a fresh context, and opens a pull request after one approval.
spec: skill-graph/1
experience:
  max_lessons: 20
topology:
  nodes:
    - id: goal
      type: input
      label: CHANGE REQUEST
    - id: plan
      type: orchestrator
      label: PLAN
      model: sonnet
      tools: [Read, Grep, Glob]
    - id: implement
      type: worker
      label: IMPLEMENT (loops on tests)
      model: sonnet
      tools: [Read, Grep, Glob, Edit, Write, Bash]
      check: npm test
      loop:
        until: check
        max_iterations: 3
      risk: wide
    - id: diff
      type: code
      label: COLLECT DIFF
      run: git diff --stat && git diff
    - id: review_correctness
      type: worker
      label: "REVIEW: Correctness"
      isolated_context: true
      model: haiku
      tools: [Read, Grep, Glob]
    - id: review_security
      type: worker
      label: "REVIEW: Security"
      isolated_context: true
      model: haiku
      tools: [Read, Grep, Glob]
    - id: gate
      type: verifier
      label: GATE (Fresh Context)
      isolated_context: true
      model: opus
      tools: [Read, Grep, Glob]
      gate: No blocking finding is left open, and every finding cites a line of the diff.
      on_fail: retry
      max_retries: 2
      retry_target: implement
    - id: approve
      type: approval
      label: APPROVE PULL REQUEST
    - id: publish
      type: agent
      label: OPEN PULL REQUEST
      model: haiku
      tools: [Bash]
      risk: irreversible
      on_fail: stop
  edges:
    - from: goal
      to: plan
    - from: plan
      to: implement
      contract: change_plan
    - from: implement
      to: diff
    - from: diff
      to:
        - review_correctness
        - review_security
        - gate
      contract: diff_text
    - from:
        - review_correctness
        - review_security
      to: gate
      contract: review_findings
    - from: gate
      to:
        - approve
        - publish
      contract: verdict
    - from: approve
      to: publish
contracts:
  change_plan:
    format: markdown
    description: The files to change, what changes in each, and the tests that prove it.
  diff_text:
    format: text
    description: The output of git diff, unchanged.
  review_findings:
    format: markdown
    description: A numbered list; each finding cites a file and line of the diff and says blocking or minor.
  verdict:
    format: markdown
    description: PASS or FAIL, the findings kept with their evidence, and a three-line summary of the change.
---

# Node Prompts & Edge Contracts

## @node: plan
Read the code this request touches and write a short plan: the files to change, what changes in each, and the tests to add or update.

The request:
{{goal}}

## @node: implement
Implement this plan. Change only the files it names; add or update the tests it lists.

{{plan.output}}

Return a short summary of what you changed.

## @node: review_correctness
Review ONLY correctness: logic errors, missed edge cases, broken contracts and tests that do not test the change.

{{diff.output}}

## @node: review_security
Review ONLY security: injection, missing authorization, secrets, unsafe input handling.

{{diff.output}}

## @node: gate
You see only the diff and the two reviews, not how the change was made. Keep the findings that the diff supports, drop the rest, and decide whether anything blocking is left.

Diff:
{{diff.output}}

Reviews:
{{review_correctness.output}}

{{review_security.output}}

## @node: approve
Show the verdict and the diff summary, then ask: open a pull request with this change?

## @node: publish
The user approved: {{approve.output}}

Commit the change on a new branch, push it, and open a pull request. Use the summary in this verdict as its description:
{{gate.output}}